Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use QDebugStateSaver to reset debug formatting #4358

Merged
merged 4 commits into from
Oct 6, 2021
Merged

Use QDebugStateSaver to reset debug formatting #4358

merged 4 commits into from
Oct 6, 2021

Conversation

Holzhaus
Copy link
Member

@Holzhaus Holzhaus commented Oct 6, 2021

No description provided.

@Holzhaus Holzhaus added this to the 2.4.0 milestone Oct 6, 2021
@Holzhaus Holzhaus added this to In Progress in Semanting Type Refactoring via automation Oct 6, 2021
uklotzde
uklotzde suggested changes Oct 6, 2021
View reviewed changes
Copy link
Contributor

@uklotzde uklotzde left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please move the implementations into the .cpp file to avoid cluttering the header. This requires adding frame.cpp.

@github-actions github-actions bot added the build label Oct 6, 2021
@Holzhaus Holzhaus requested a review from uklotzde October 6, 2021 15:44
uklotzde
uklotzde approved these changes Oct 6, 2021
View reviewed changes
Copy link
Contributor

@uklotzde uklotzde left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@uklotzde uklotzde merged commit 47fc290 into mixxxdj:main Oct 6, 2021
Semanting Type Refactoring automation moved this from In Progress to Done Oct 6, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@uklotzde uklotzde uklotzde approved these changes

Assignees
No one assigned
Labels
build
Projects
Semanting Type Refactoring
Status: Done
Semanting Type Refactoring
Done
Milestone
2.4.0
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@Holzhaus @uklotzde